-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing express methods constants for the frontend #3824
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having constants, but having to use camelCase
everywhere seems confusing.
Having the constants with the same prefix and in the same place as the other payment methods constants might lead to the wrong assumption that they behave the same way (can be used without the need of the camelCase wrapper)
You're right, Diego. I have updated the code in dd8fb3e to introduce specific constants for this use case. What do you think? I want to convert the constants.js file into a new folder with files for each constant type, but I think it is better to leave that for another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @wjrosa.
It looks good, I'm pre-approving this because the conflicts look minor (just a couple of imports).. but happy to re-test this after you solve them if you want.
Changes proposed in this Pull Request:
This PR introduces new constants for the express payment methods (Google Pay, Apple Pay, Link and Amazon Pay). And also implements them on the codebase.
Testing instructions
Code review should be enough. Check if the tests are still passing.
changelog.txt
andreadme.txt
(or does not apply)Post merge