Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using constants in payment methods map file #3852

Merged
merged 36 commits into from
Feb 13, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 6, 2025

Changes proposed in this Pull Request:

This PR adds the payment method constants (frontend version) to the payment method map file. It also introduces new constants for the newest methods.

Testing instructions

Code review should be enough. Check if tests are still passing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Feb 6, 2025
@wjrosa wjrosa marked this pull request as ready for review February 10, 2025 13:34
@wjrosa wjrosa requested a review from diegocurbelo February 10, 2025 14:08
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Base automatically changed from fix/3804-refactor-deferred-intent to develop February 13, 2025 10:02
@wjrosa wjrosa enabled auto-merge (squash) February 13, 2025 12:17
@wjrosa wjrosa merged commit 255b080 into develop Feb 13, 2025
37 checks passed
@wjrosa wjrosa deleted the dev/using-constants-in-payment-methods-map-file branch February 13, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants