-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using constants in payment methods map file #3852
Merged
wjrosa
merged 36 commits into
develop
from
dev/using-constants-in-payment-methods-map-file
Feb 13, 2025
Merged
Using constants in payment methods map file #3852
wjrosa
merged 36 commits into
develop
from
dev/using-constants-in-payment-methods-map-file
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merce/woocommerce-gateway-stripe into fix/3804-refactor-deferred-intent
Co-authored-by: César Costa <[email protected]>
…ants-in-payment-methods-map-file
Co-authored-by: César Costa <[email protected]>
…merce/woocommerce-gateway-stripe into fix/3804-refactor-deferred-intent
…ants-in-payment-methods-map-file
diegocurbelo
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Base automatically changed from
fix/3804-refactor-deferred-intent
to
develop
February 13, 2025 10:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds the payment method constants (frontend version) to the payment method map file. It also introduces new constants for the newest methods.
Testing instructions
Code review should be enough. Check if tests are still passing.
changelog.txt
andreadme.txt
(or does not apply)Post merge