-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Universal Analytics #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting Add product identifier setting
…pages Update tracking for classic pages
Deny all for EEA visitors. Document the customization snippet.
to cover the quirks of wcgaiData not being loaded otherwise.
I found an issue that when you add (in a snippet or another extension) another script that has a dependency on Steps to reproduce
add_action( 'wp_enqueue_scripts', function () {
wp_register_script( 'my-code', '', array('woocommerce-google-analytics-integration'), null, false );
wp_add_inline_script( 'my-code', "console.log('Hello');" );
wp_enqueue_script( 'my-code' );
} );
|
Co-authored-by: martynmjones <[email protected]>
not to let it register its `gtag` function so that we could provide a more detailed configuration. Co-authored-by: martynmjones <[email protected]>
Set up tracker synchronously once the script is loaded (possibly in the `<head>`). Track classic WC events only after data is ready and the document is loaded - at leas on `wp_footer`. Address #322 (comment)
4 tasks
after #363
Co-authored-by: martynmjones <[email protected]>
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #215
Checks:
Changelog entry