Fix related products E2Es for WC9.5 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This run didn't pass. I got the same failure in a local run. |
|
Thanks. I forgot to migrate the adjusted selector. Now, the run is passing https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/12383008805 |
eason9487
approved these changes
Dec 18, 2024
|
Hi @tomalec, I will address #481 (comment) and merge this PR to make the later release process a bit smoother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adjusts E2E tests for WC 9.5 changes.
In WC 9.5, by default, there is no related products section on a single product page - I made the test skip in such a case.
Also, I added a "related" tag to all simple products to make sure simple products will appear in the related products section instead of "Cat teasers" - without the "Add to cart" button.
Screenshots:
Detailed test instructions:
9.5.0-rc.1- https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/123628678719.4.0- https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/12383008805Additional details:
create*PagesChangelog entry