-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] [Design System] Apply straightforward color updates #15068
base: feat/ds-color-palette
Are you sure you want to change the base?
Conversation
…e` - they might change when implementing the components like buttons.
… `posSurfaceContainerLowest`.
… tappable. Button styles will be updated separately.
…a notice component separately.
…d separately as a component.
…r to `posOnSuccess`.
|
@iamgabrielma @joshheald @staskus 👋 If you think the PR should be merged to a feature branch, please let me know. I personally prefer merging to trunk so that we can catch any unexpected issues earlier with more devs working on other parts of the app and we won't end up with a giant PR. Additionally, there are 0/few production usage of POS and I think it's safe to apply design changes incrementally as long as the PRs don't introduce UI/UX issues. However, if you have concerns over shipping it (I will also only merge this PR after the release 21.7 code freeze is cut), I'm happy to create a feature branch and merge this PR to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks good! I haven't seen anything off while testing the normal cash/card/receipt flows, agree that we should make these in trunk rather than feature branch, so it's easier to catch if there's something off either with the colours or design-wise.
🚢
@@ -1,4 +1,5 @@ | |||
import Foundation | |||
import SwiftUICore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 👀 was this a SwiftUI
import maybe?
Part of #15061
Description
This PR applies a few straightforward color updates to replace the previous POS color usage so that a few previous POS colors can be removed. The remaining colors will be replaced when components are created/updated:
Color Scheme Updates:
Renamed 3 text color properties in
Color+POSColorPalette.swift
to replace the previous corresponding text colors:posTextPrimary
toposPrimaryText
posTextSecondary
toposSecondaryText
posTextTertiary
toposTertiaryText
Updated color references in
CardReaderConnectionStatusView.swift
:Color(.wooCommerceEmerald(.shade40))
toColor.posSuccess
for circle iconsColor(.wooCommercePurple(.shade60))
to.posPrimaryText
for disconnected font colorBackground Color Updates:
Color.posPrimaryBackground
toColor.posSurface
inPointOfSaleCardPresentPaymentFoundMultipleReadersView.swift
Color.posSecondaryBackground
toConstants.backgroundColor
in multiple views includingItemListErrorCardView.swift
,ParentProductCardView.swift
,SimpleProductCardView.swift
, andVariationCardView.swift
[1] [2] [3] [4]Other Changes:
backgroundColor
constant inPointOfSaleItemListCardConstants.swift
to centralize background color usageItemListView.swift
andItemRowView.swift
[1] [2] [3]Steps to reproduce
The color changes are quite scattered (I could make smaller PRs for each smaller part, but I thought it's more efficient to change a bunch with reasonable diffs so that the reviewer(s) don't have to test it many times.
I'd suggest testing the PR by launching POS, adding some product/variation(s) to cart, checking out, paying with a card & cash, emailing receipt, and starting a new order. Other things to test:
Testing information
Screenshots
Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-02-06.at.16.31.41.mp4
Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-02-06.at.16.33.10.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: