-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background image upload: Fix issue showing uploaded images while saving is in progress #15107
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
override func prepareForReuse() { | ||
super.prepareForReuse() | ||
syncingOverlayView?.removeFromSuperview() | ||
selectedProductImageOverlayView?.removeFromSuperview() | ||
syncingOverlayView = nil | ||
selectedProductImageOverlayView = nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempt an additional fix for the reuse issue mentioned in #15052.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have fixed the issue, I'm not able to replicate it anymore! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected 👏
Closes: #15093
Description
This PR fixes the issue when uploaded images are not displayed when background image saving is in progress.
The solution:
hasUnsavedChangesOnImages
.Steps to reproduce
Testing information
Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that:
Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-11.at.17.11.41.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: