Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde, change BlockQuote -> Blockquote #135

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix serde, change BlockQuote -> Blockquote #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66a8618
Fixed mdast serde
h7kanna Sep 14, 2024
981b823
Added json feature in coverage action
h7kanna Sep 15, 2024
bf4d60d
Fixed serde test configuration
h7kanna Sep 15, 2024
323607c
Renamed BlockQuote to Blockquote
h7kanna Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
- uses: dtolnay/rust-toolchain@v1
with:
toolchain: stable
- run: cargo install cargo-tarpaulin && cargo tarpaulin --out xml
- run: cargo install cargo-tarpaulin && cargo tarpaulin --features json --out xml
- uses: codecov/codecov-action@v4
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ serde = { version = "1", features = ["derive"], optional = true }
env_logger = "0.11"
criterion = "0.5"
pretty_assertions = "1"
serde_json = { version = "1" }
swc_core = { version = "0.100", features = [
"ecma_ast",
"ecma_visit",
Expand Down
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,15 +254,15 @@ The following bash scripts are useful when working on this project:
```
* format:
```sh
cargo fmt && cargo fix --all-targets
cargo fmt && cargo fix --all-targets --all-features
```
* lint:
```sh
cargo fmt --check && cargo clippy --examples --tests --benches --all-features
cargo fmt --check && cargo clippy --examples --tests --benches --all-features --all-features
```
* test:
```sh
RUST_BACKTRACE=1 cargo test
RUST_BACKTRACE=1 cargo test --all-features
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recommend that humans run both commands? One or the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be replaced with 'cargo test --all-features'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can you do that? One test example, with all-features?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* docs:
```sh
Expand Down
Loading