Skip to content

Commit

Permalink
refactor: indexOf 연산을 사용하지 않기 위한 리팩토링
Browse files Browse the repository at this point in the history
- requests로 stream을 돌리지 않고 ,IntStream을 통해 index 기반 접근하여 반환하도록 수정했습니다.
  • Loading branch information
miiiinju1 committed Aug 25, 2024
1 parent 3601073 commit caf8bea
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Component;

Expand Down Expand Up @@ -73,8 +74,10 @@ private boolean isEmptyRequest(List<CreateLogRequest> requests,
*/
private List<CreateLogRequest> filterValidRequests(List<CreateLogRequest> requests,
List<String> errorMessages) {
return requests.stream()
.filter(request -> isValidRequest(request, requests.indexOf(request), errorMessages))

return IntStream.range(0, requests.size())
.filter(index -> isValidRequest(requests.get(index), index + 1, errorMessages))
.mapToObj(requests::get)
.toList();
}

Expand All @@ -93,7 +96,7 @@ private boolean isValidRequest(CreateLogRequest request, int index,
String message = violations.stream()
.map(ConstraintViolation::getMessage)
.collect(Collectors.joining(", "));
errorMessages.add("Request " + (index + 1) + ": " + message);
errorMessages.add("Request " + index + ": " + message);
return false;
}
return true;
Expand Down

0 comments on commit caf8bea

Please sign in to comment.