Skip to content

Commit

Permalink
서포터 선택 필터 기능 useEffect dependency 수정 (#200)
Browse files Browse the repository at this point in the history
* fix: supporterId와 key값이 겹치는 오류 수정

* fix: 무한으로 useEffect가 호출되는 오류 수정
  • Loading branch information
gyeongza authored Aug 3, 2023
1 parent b026061 commit d2c1248
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ const SupporterSelectItem = ({
<S.Name tabIndex={0}>{name}</S.Name>
<S.Company tabIndex={0}>{company}</S.Company>
<S.TechStackContainer>
{technicalTags.map((tag, index) => (
<TechLabel key={index} tag={tag} />
{technicalTags.map((tag) => (
<TechLabel key={tag} tag={tag} />
))}
</S.TechStackContainer>
<S.CompletedReviewContainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const SupporterSelectList = ({ handleSelectButton, selectedTechField }: Props) =
});
if (backend) setFilteredSupporter(backend);
}
}, [filteredSupporter, supporterCardList]);
}, [supporterCardList, selectedTechField]);

const selectedSupporter = (selectedSupporter: SupporterCard) => {
handleSelectButton(selectedSupporter);
Expand Down

0 comments on commit d2c1248

Please sign in to comment.