Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 핀(Pin) 패키지 코드 리팩터링(PinImage 기능 구현 포함) #240

Merged
merged 130 commits into from
Aug 9, 2023

Commits on Jul 18, 2023

  1. [Docs] GitHub Issue 및 PR Template 설정 (#37)

    * chore: .gitignore 추가
    
    * chore: GitHub PR 및 Issue Template
    
    * Revert "chore: GitHub PR 및 Issue Template"
    
    This reverts commit 65915f7.
    
    * Revert "chore: .gitignore 추가"
    
    This reverts commit 1e1865a.
    
    * chore: .gitignore 추가
    
    * chore: GitHub Issue 및 PR Template 추가
    junpakPark authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8646b1a View commit details
    Browse the repository at this point in the history
  2. [Docs] GitHub Issue Template 파일명 오류 수정 (#39)

    * chore: .gitignore 추가
    
    * chore: GitHub PR 및 Issue Template
    
    * Revert "chore: GitHub PR 및 Issue Template"
    
    This reverts commit 65915f7.
    
    * Revert "chore: .gitignore 추가"
    
    This reverts commit 1e1865a.
    
    * chore: .gitignore 추가
    
    * chore: GitHub Issue 및 PR Template 추가
    
    * chore: GitHub Issue 및 PR Template 추가
    junpakPark authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5b153cc View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    c54a142 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1397964 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    4efef6e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. feat: member 구현 중

    Co-authored-by: jaeyeon kim <[email protected]>
    junpakPark and kpeel5839 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    29997b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82233e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. feat: 패키지 분리, AuthMember 구현

    Co-authored-by: jaeyeon kim <[email protected]>
    junpakPark and kpeel5839 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    70f351f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b98ce02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd32df0 View commit details
    Browse the repository at this point in the history
  4. feat: AuthTopic 구현

    kpeel5839 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    69268ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f6faad0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    960b9b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    68838dc View commit details
    Browse the repository at this point in the history
  8. refactor: API 명세 수정을 위한 임의 커밋

    Co-authored-by: jaeyeon kim <[email protected]>
    junpakPark and kpeel5839 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5bda12f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    83f79ff View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    27a0738 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    41ee4ef View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b0850af View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    9ffcefd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    471a826 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5075d4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30a97f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. refactor: .. 지송;;^^

    - 패키지 재분배
    - AUTH 관련 기능 구현
    - TopicController 및 LocationController 분리
    
    Co-authored-by: jaeyeon kim <[email protected]>
    junpakPark and kpeel5839 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    470fcb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b58830 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80d7e9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    939964c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    12e83b4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8c869a1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7bdea8a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5cf4318 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc4c0c4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b45f3b1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0dec766 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    c451958 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2433935 View commit details
    Browse the repository at this point in the history
  3. test: AddressTest 추가

    junpakPark committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4383f25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    209a4e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d6e4e7a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    712a289 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    846490a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cd57810 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6626b7e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    02979b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    be59142 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d81886 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2dccd5f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    975fffd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6cc09a4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dc90aa5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a78a348 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    426ad35 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    53db76c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    008ff66 View commit details
    Browse the repository at this point in the history
  11. refactor: Pin 예외 메시지 수정

    - #127 과 내용 통일
    yoondgu committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f1a32de View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    92879ef View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1a825b5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f8370c3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    52fa017 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d0d56a9 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1520467 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2f48f41 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9e97c05 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b9a18fc View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d6188c4 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8ffb1f3 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    9a8a019 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    fa6d7fe View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    0dad751 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    bb84223 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    71e970a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    d5128c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5423ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37a79a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    36ac58e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    342f35e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    864b851 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3fa28bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6b3696f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9192536 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    522708f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0815ff7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7fcc517 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2ea4a21 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e521b2c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e2bb58e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9d04afb View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    96d3512 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    019f330 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Merge remote-tracking branch 'origin/feature/member-#161' into be-ref…

    …actor/pin
    
    # Conflicts:
    #	backend/src/test/java/com/mapbefine/mapbefine/pin/presentation/PinControllerTest.java
    yoondgu committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    5bfb799 View commit details
    Browse the repository at this point in the history
  2. refactor: Pin 생성 시 PinInfo를 묶어서 받도록 수정, 중복 테스트 제거

    - PinInfo의 필드인 name, description을 직접 받는 대신 PinInfo를 받도록 함.
    - PinInfo의 필드가 추가될 경우에 Pin의 생성자도 수정할 필요가 없도록 함.
    - PinTest에서 PinInfoTest와 중복되는 테스트 제거
    - PinInfo 업데이트 시 새 객체 할당하도록 하여 검증이 필요한 로직 최소화 (update 관련 테스트 삭제)
    yoondgu committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    e010527 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d8497f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    196f669 View commit details
    Browse the repository at this point in the history
  5. refactor: PinImage 생성 시 Image 객체를 전달받도록 수정, getter 추가

    - Pin 리팩터링과 마찬가지로, Image의 필드 추가 시에도 생성 메서드 시그니처 변경할 필요 없도록 함.
    - imageUrl에 어떤 검증 로직이 있는지 명시적으로 보여줄 수 있음.
    yoondgu committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    7fee7a8 View commit details
    Browse the repository at this point in the history
  6. chore: member-#161,173 pull 받은 후 충돌 해결

    - pull 받은 코드 중 MemberCommandServiceTest 의 실패하는 테스트 주석 처리함
    yoondgu committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    ca4f77a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f3350cd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b394b0f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    83339d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Configuration menu
    Copy the full SHA
    9367605 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    00c83dd View commit details
    Browse the repository at this point in the history
  2. test: 중복되는 내용의 PinCommandServiceTest 테스트 삭제

    - 하위 계층에서 테스트하는 내용에 대해 테스트하는 메서드 삭제
    yoondgu committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    413ee7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3ac82e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6459767 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    799a264 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7310146 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c0bfc7d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dbb4523 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1335e0e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    05293f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Configuration menu
    Copy the full SHA
    8a976a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6354f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b339a33 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20238ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    91307a1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3941aef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c461d82 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    882b88b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3e26e65 View commit details
    Browse the repository at this point in the history
  10. refactor: Pin 서비스 클래스 메서드 분리

    - 조회 및 예외처리 로직 메서드 분리
    - 검증 로직 메서드 분리 (TopicCommandService 와 분리 방식 통일)
    yoondgu committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e4a7cde View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4e50b84 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ce0855d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8ddcabf View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9639360 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5fbd5ac View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    43ca6c2 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    27bef77 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    56a13c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    e12532d View commit details
    Browse the repository at this point in the history
  2. refactor: 정적 팩터리 메서드 내부에서 객체 생성하도록 변경

    - 정적 팩터리 메서드를 의미있게 사용하기 위함
    - 다른 도메인에서의 코드와의 통일성을 위해 변경함
    yoondgu committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c8875b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3968a39 View commit details
    Browse the repository at this point in the history