feat: 스터디 정보 수정 기능 구현 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevstevie
approved these changes
Aug 9, 2023
| import javax.validation.constraints.NotBlank; | ||
| import javax.validation.constraints.Positive; | ||
|
|
||
| public record StudyUpdateRequest( |
There was a problem hiding this comment.
완전히 똑같다면 같은 리퀘스트를 재활용해도 될 것 같아요
| Given "jinwoo"가 제목-"자바", 정원-"6"명, 예상시작일-"5"일 뒤, 총 회차-"5"회, 주기-"1w", 소개-"수정 전 스터디 소개"로 스터디를 개설한다. | ||
| When "jinwoo"가 "자바" 스터디의 정보를 제목-"자바스크립트", 정원-"8"명, 예상시작일-"3"일 뒤, 총 회차-"6"회, 주기-"5d", 소개-"수정 후 스터디 소개"로 수정한다. | ||
| When "jinwoo"가 스터디 상세 조회에서 이름이 "자바스크립트"인 스터디를 조회한다. | ||
| Then 스터디 상세조회 결과가 제목-"자바스크립트", 정원-"8"로 조회된다. |
poi1649
approved these changes
Aug 9, 2023
| @Transactional | ||
| public void update(Member member, Long studyId, StudyUpdateRequest request) { | ||
| Study study = findStudyById(studyId); | ||
| study.validateMaster(member); |
There was a problem hiding this comment.
p1: validate 메서드를 updateInformation 안에서 호출하는게 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
스터디 정보 수정 기능 구현
🙏 PR Point
StudyUpdateRequest와 StudyCreateRequest의 코드가 완전히 일치하는데, 여러분들은 이거에 대해서 어떻게 생각하시나요??
👍 관련 이슈