스터디 완료시 티어 변경하는 기능 추가 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevstevie
requested changes
Aug 9, 2023
| @@ -79,6 +80,12 @@ public String getIntroduction() { | |||
| return introduction.getIntroduction(); | |||
| } | |||
|
|
|||
| public void updateTier() { | |||
There was a problem hiding this comment.
updateTier보다 올린다는 의미가 들어가면 좋을 것 같아요
| @@ -242,6 +232,7 @@ private void updateCurrentRound(Round upcomingRound) { | |||
|
|
|||
| private void finishStudy() { | |||
| this.processingStatus = ProcessingStatus.END; | |||
| currentRound.updateTier(); | |||
There was a problem hiding this comment.
라운드의 티어를 올리는게 아니라서 부적절한 네이밍같아요
kevstevie
approved these changes
Aug 9, 2023
yujamint
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
👍 관련 이슈