Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[설정 뷰] 설정 뷰 기능 작업 #269

Merged
merged 5 commits into from
Aug 9, 2023
Merged

[설정 뷰] 설정 뷰 기능 작업 #269

merged 5 commits into from
Aug 9, 2023

Conversation

inseonyun
Copy link
Member

😋 작업한 내용

  • 설정 뷰 기능 작업

🙏 PR Point

  • remote 단계에서 ViewModel 및 테스트 코드 작성 예정
  • SettingActivity 내에 있는 코드는 그대로 두게 될 거 같은데 MVVM스럽나요?

👍 관련 이슈

@inseonyun inseonyun added android💚 안드 feat 기능 추가 선희☀️ 써니 labels Aug 9, 2023
@inseonyun inseonyun self-assigned this Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Test Results

15 tests   15 ✔️  3s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit ecfab20.

♻️ This comment has been updated with latest results.

s9hn
s9hn approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@s9hn s9hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

RightHennessy
RightHennessy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@RightHennessy RightHennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 매우 interesting한 구현이네요..
이렇게 리사이클러뷰로 구현하는게 일반적인 방식인가요? (진짜 몰라서 물어봄)

@inseonyun
Copy link
Member Author

inseonyun commented Aug 9, 2023 •
edited
Loading

오.. 매우 interesting한 구현이네요.. 이렇게 리사이클러뷰로 구현하는게 일반적인 방식인가요? (진짜 몰라서 물어봄)

아뇨 저도 몰라요
그냥 같은 뷰가 반복 되길래 리스트뷰/리사이클러뷰로 쓰려고 했었습니다.
이렇게 하면 장점은 추후 설정에 대한 아이템들을 서버에서 받아오는 경우 변화에 대응하기 쉽고, 설정 화면에서 광고를 게시하는 경우는 없겠지만 그런 장점도 있을 거 같아요
단점으로는 설정의 수가 많아진다면 이에 대한 이벤트 분기 처리 및 코드가 더러워질 수 있겠네용

@inseonyun inseonyun merged commit ba51986 into develop Aug 9, 2023
2 checks passed
@inseonyun inseonyun deleted the AN/feature/253-setting-inflate branch August 9, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RightHennessy RightHennessy RightHennessy approved these changes

@s9hn s9hn s9hn approved these changes

Assignees

@inseonyun inseonyun

Labels
android💚 안드 feat 기능 추가 선희☀️ 써니
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[설정 뷰] 설정 뷰 기능 작업
3 participants
@inseonyun @s9hn @RightHennessy