[AN] 홈뷰 구조 리팩터링 #594
Merged
[AN] 홈뷰 구조 리팩터링 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1msh
approved these changes
Oct 31, 2023
inseonyun
approved these changes
Nov 6, 2023
Comment on lines
+8
to
+19
| abstract class BindingViewActivity<VB : ViewBinding>( | ||
| private val bindingInflater: (LayoutInflater) -> VB, | ||
| ) : AppCompatActivity() { | ||
| private var _binding: VB? = null | ||
| val binding get() = _binding!! | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| _binding = bindingInflater(layoutInflater) | ||
| setContentView(binding.root) | ||
| } | ||
| } |
Comment on lines
+39
to
+40
| is HomeUiState.Loading -> {} | ||
| is HomeUiState.Failed -> {} |
There was a problem hiding this comment.
Suggested change
| is HomeUiState.Loading -> {} | |
| is HomeUiState.Failed -> {} | |
| is HomeUiState.Loading -> Unit | |
| is HomeUiState.Failed -> Unit |
How about this?
| when (userStudies.isEmpty()) { | ||
| true -> binding.tvHomeNoStudy.visibility = View.VISIBLE | ||
| false -> { | ||
| binding.tvHomeNoStudy.visibility = View.INVISIBLE |
There was a problem hiding this comment.
How about View.GONE ?
Why use View.INVISIBLE?
| } | ||
| val uiState: StateFlow<HomeUiState> = flow { emit(userStudyRepository.getUserStudies()) } | ||
| .map { HomeUiState.Success(it) } | ||
| .catch { HomeUiState.Failed } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
변경사항이 굉장히 많습니다
홈뷰의 대대적인 구조개편을 진행했습니다.
데이터레이어(데이터모델) - 도메인레이어(유즈케이스, 옵셔널) - 뷰모델(uiState, HotFlow) - 뷰(ViewBinding)
👍 관련 이슈
기획의 어떤 부분을 구현 / 수정했는가 (굉장히 상세하게 적어주세요, 해당 커밋의 링크, 코드의 위치를 남겨주면 더욱 좋습니다.)
밑은 예시입니다.
시작되면서 스터디의 주 몇 회 정보를 유저가 실제로 선택한 일 수로 수정
스터디가 더 이상 종료되지 않도록 수정