feat: 식품 필터링 정보 메타데이터 조회 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkmuhyeun
reviewed
Aug 2, 2023
backend/src/main/java/zipgo/petfood/application/PetFoodQueryService.java
Show resolved
Hide resolved
backend/src/main/java/zipgo/petfood/presentation/PetFoodController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/zipgo/petfood/domain/repository/PetFoodRepository.java
Outdated
Show resolved
Hide resolved
| List<String> primaryIngredients = petFoodRepository.findAllPrimaryIngredients().stream() | ||
| .map(primaryIngredient -> asList(primaryIngredient.split(","))) | ||
| .flatMap(Collection::stream) | ||
| .distinct() |
There was a problem hiding this comment.
@query에서 distinct하고 있는데 여기서도 해야되나용
There was a problem hiding this comment.
아 이게 query에서는 로우 레벨에서 한 번 걸러주고, 애플리케이션에서는 ,로 구분 후 List에서 중복 제거합니다!
Closed
1 task
parkmuhyeun
previously approved these changes
Aug 2, 2023
kyY00n
previously approved these changes
Aug 2, 2023
backend/src/main/java/zipgo/petfood/domain/repository/PetFoodRepository.java
Outdated
Show resolved
Hide resolved
parkmuhyeun
previously approved these changes
Aug 2, 2023
iamjooon2
reviewed
Aug 2, 2023
backend/src/main/java/zipgo/petfood/domain/repository/PetFoodRepository.java
Show resolved
Hide resolved
backend/src/main/java/zipgo/petfood/application/PetFoodQueryService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More