Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 반려동물 정보 등록 API 기능 #257

Merged
merged 28 commits into from
Aug 16, 2023
Merged

feat: 반려동물 정보 등록 API 기능 #257

merged 28 commits into from
Aug 16, 2023

Conversation

iamjooon2
Copy link
Collaborator

@iamjooon2 iamjooon2 commented Aug 15, 2023 •
edited
Loading

📄 Summary

#245

🙋🏻 More

사진 업로드 API와 반려동물 등록 API 두개를 분리하였음
S3 업로드는 캠퍼스 EC2 가서 테스트 가능....

700라인 미안해요..

@iamjooon2 iamjooon2 added this to the 4차 데모데이 milestone Aug 15, 2023
@iamjooon2 iamjooon2 self-assigned this Aug 15, 2023
@iamjooon2 iamjooon2 marked this pull request as draft August 15, 2023 06:42
@iamjooon2 iamjooon2 changed the title feat: 반려동물 정보 등록 API 구현 feat: 반려동물 정보 등록 API 구현 & 사진 업로드 API Aug 15, 2023
@iamjooon2 iamjooon2 marked this pull request as ready for review August 15, 2023 07:09
@iamjooon2 iamjooon2 changed the title feat: 반려동물 정보 등록 API 구현 & 사진 업로드 API feat: 반려동물 정보 등록 API 기능 Aug 15, 2023
@iamjooon2 iamjooon2 linked an issue Aug 15, 2023 that may be closed by this pull request
[BE] 반려동물 정보 등록 기능 #237
Closed
1 task
parkmuhyeun
parkmuhyeun reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@parkmuhyeun parkmuhyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s3 짜느라 고생 많았다잇~ 가비 이번에 신기한거 다 체험해보노ㅋㅋㅋㅋ

backend/src/main/java/zipgo/ZipgoApplication.java Outdated Show resolved Hide resolved
backend/src/main/java/zipgo/image/application/ImageService.java Show resolved Hide resolved
backend/src/main/java/zipgo/image/infrastructure/aws/s3/S3Uploader.java Show resolved Hide resolved
backend/src/main/java/zipgo/image/presentaion/ImageController.java

@RestController
@RequiredArgsConstructor
@RequestMapping("/images")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageController라 하니깐 공용 image 처리하는거 같지 않나용

반려동물 controller에 있는게 더 좋을거 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 일단 4차 데모까지 사진 업로드 사용하는 게 여기밖에 없어서 사실상 공용 이미지 처리가 가능하긴 합니다🫠
이건 추후 리팩터링 해보죠

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 사실 이미지는 도메인 자체를 분리해서 이렇게 쓰는것도 괜찮은듯요

backend/src/main/java/zipgo/image/infrastructure/aws/s3/S3PetImageClient.java Show resolved Hide resolved
backend/src/main/java/zipgo/pet/presentation/dto/request/CreatePetRequest.java
Comment on lines +14 to +15

String image,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 14번째 줄은 붙치고 15번째 아래는 개행 아닌가용

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 저는 명시적으로 띄워주는 걸로 생각했어요
우리 엔티티 필드 각각 개행하듯이요!
아래는 개행할게요~!

backend/src/main/java/zipgo/pet/application/ImageClient.java Show resolved Hide resolved
backend/src/main/resources/application-dev.yml Show resolved Hide resolved
backend/src/test/java/zipgo/image/presentaion/ImageControllerTest.java Outdated Show resolved Hide resolved
backend/src/test/java/zipgo/image/presentaion/ImageControllerTest.java Outdated Show resolved Hide resolved
kyY00n
kyY00n reviewed Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@kyY00n kyY00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어!!!
근데 왜 어프룹이 안되징..

backend/src/main/java/zipgo/pet/presentation/dto/request/CreatePetRequest.java Show resolved Hide resolved
backend/src/main/resources/application-dev.yml Show resolved Hide resolved
backend/src/main/java/zipgo/image/application/ImageService.java
private final ImageClient imageClient;

public String save(MultipartFile image) {
UUID uuid = UUID.randomUUID();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에는 사진 용도가 다양해질텐데, 그 사진들을 어떻게 분류하고 관리할지 고민해볼 수 있겠어요!! (함께)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요!! 일단 사진이 사용되는 곳이 여기 하나라서 일단 이렇게 만들었어요 🫠

kyY00n
kyY00n previously approved these changes Aug 16, 2023
View reviewed changes
wonyongChoi05
wonyongChoi05 previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@wonyongChoi05 wonyongChoi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2023-08-16 11 05 02

이거보고 울면서 코멘트 달았습니다 감동이네요 😭😭;;

backend/src/main/java/zipgo/image/infrastructure/aws/s3/S3Uploader.java Show resolved Hide resolved
backend/src/main/java/zipgo/image/infrastructure/aws/s3/S3Uploader.java Show resolved Hide resolved
backend/src/main/java/zipgo/image/presentaion/ImageController.java

@RestController
@RequiredArgsConstructor
@RequestMapping("/images")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 사실 이미지는 도메인 자체를 분리해서 이렇게 쓰는것도 괜찮은듯요

backend/src/main/java/zipgo/image/presentaion/ImageController.java Show resolved Hide resolved
backend/src/main/java/zipgo/pet/presentation/dto/request/CreatePetRequest.java Show resolved Hide resolved
backend/src/main/java/zipgo/pet/presentation/dto/request/CreatePetRequest.java Outdated Show resolved Hide resolved
backend/src/main/java/zipgo/common/config/AdditionalConfiguration.java
Comment on lines +8 to +13
@Configuration
@EnableConfigurationProperties({
KakaoCredentials.class,
JwtCredentials.class,
AwsS3Credentials.class
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키야~ 감탄하고갑니다;; 야무지게 분리해놨노

@iamjooon2 iamjooon2 dismissed stale reviews from wonyongChoi05 and kyY00n via 9993ea4 August 16, 2023 02:05
parkmuhyeun
parkmuhyeun approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@parkmuhyeun parkmuhyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가즈아ㅏㅏ

backend/src/main/java/zipgo/common/config/AdditionalConfiguration.java
KakaoCredentials.class,
JwtCredentials.class,
AwsS3Credentials.class
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@iamjooon2 iamjooon2 merged commit a78902a into develop Aug 16, 2023
1 check passed
@iamjooon2 iamjooon2 deleted the feature/#237 branch August 16, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonyongChoi05 wonyongChoi05 wonyongChoi05 approved these changes

@parkmuhyeun parkmuhyeun parkmuhyeun approved these changes

@kyY00n kyY00n kyY00n left review comments

Assignees

@iamjooon2 iamjooon2

Labels
🕋 Backend ✨ Feature
Projects
2023-zipgo
Status: Done
Milestone
4차 데모데이
Development

Successfully merging this pull request may close these issues.

[BE] 반려동물 정보 등록 기능
4 participants
@iamjooon2 @kyY00n @parkmuhyeun @wonyongChoi05