Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 프론트엔드 스토리북 테스트 CI 구축 #374

Merged
merged 12 commits into from
Sep 4, 2023
Merged

chore: 프론트엔드 스토리북 테스트 CI 구축 #374

merged 12 commits into from
Sep 4, 2023

Conversation

ksone02
Copy link
Member

@ksone02 ksone02 commented Sep 1, 2023

📄 Summary

close #373

🙋🏻 More

@ksone02 ksone02 added this to the 5차 데모데이 milestone Sep 1, 2023
@ksone02 ksone02 self-assigned this Sep 1, 2023
ksone02 and others added 11 commits September 1, 2023 11:32
@ksone02
fix: workflow 타겟 변경
ff50108
@ksone02
chore: storybook worflow test
5802930
@ksone02
fix: workflow 오타 수정
4e6d89b
@ksone02
chore: workflows 이름 변경
34dcdfd
@ksone02
chore: workflows 문법 변경
fd7f016
@ksone02
chore: workflows pr branch 추가 테스트
f1a571c
@n0eyes @ksone02
feat: 로그인 여부 확인 로직 수정, zipgoLocalStorage 추가 (#375)
43f8b10 
* refactor: 유니온 undefined를 옵셔널 타입으로 변경

* feat: localStorageKit 추가

* refactor: User 타입 분리 및 사용하지 않는 PetProfile 타입 제거

* feat: Tokens type 추가

* fix: useContextInScope 제거 > useContext로 변경

* refactor: 불필요한 import 제거

* refactor: 토큰이 없는 경우 Authorization이 삽입되지 않도록 수정

* refactor: useUser 제거 및 zipgoLocalStorage로 대체

* refactor: authenticateUser api 헤더에서 토큰이 없는 경우 Authorization 제거

* refactor: localStorage 로직 > zipgoLocalStorage로 변경
@ksone02
chore: 스토리북 테스트 필요한 의존성 설치
77d5d28
@ksone02
fix: playwright devDependency로 이동
91e168d
@ksone02
chore: storybook test workflows 수정
b0f7618
@ksone02
fix: workflows target branch 변경
4fbc0f2
iamjooon2
iamjooon2 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@iamjooon2 iamjooon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./yarn 캐시파일 같이 올라온듯!

@HyeryongChoi HyeryongChoi merged commit 51cc4ae into develop Sep 4, 2023
1 check passed
@wonyongChoi05 wonyongChoi05 deleted the feature/#373-1 branch September 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjooon2 iamjooon2 iamjooon2 approved these changes

@HyeryongChoi HyeryongChoi HyeryongChoi approved these changes

@n0eyes n0eyes Awaiting requested review from n0eyes n0eyes is a code owner

@parkmuhyeun parkmuhyeun Awaiting requested review from parkmuhyeun parkmuhyeun is a code owner

@wonyongChoi05 wonyongChoi05 Awaiting requested review from wonyongChoi05 wonyongChoi05 is a code owner

@kyY00n kyY00n Awaiting requested review from kyY00n kyY00n is a code owner

Assignees

@ksone02 ksone02

Labels
📚 Frontend ⚙️ Setting
Projects
2023-zipgo
Status: Done
Milestone
5차 데모데이
Development

Successfully merging this pull request may close these issues.

[FE] 스토리북 테스트 자동화 구축
4 participants
@ksone02 @HyeryongChoi @iamjooon2 @n0eyes