totalPages => paginationSizes 로 변경 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hain-tain
changed the title
Jaymyong66
approved these changes
Nov 14, 2024
frontend/src/mocks/handlers.ts
Outdated
Comment on lines
64
to
65
| const totalElements = filteredTemplates.length; | ||
| const totalPages = Math.ceil(totalElements / size); | ||
| const paginationSizes = Math.min(Math.ceil(totalElements / size - page + 1), 5); |
There was a problem hiding this comment.
그럼 여기서 totalElements도 필요 없을까요?!
|
멋져요!! |
…de-zap into refactor/899-remove-totalPages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
📍주요 변경 사항
검색 성능을 올리기 위해 백엔드와 함께 api를 변경하였습니다. 이에 따라 totalPages와 totalElements 를 제거하고, paginationSizes를 적용하였습니다. (paginationSizes 는 현재 페이지를 포함하여 다음에 몇 페이지까지 있는지를 반환하는
number입니다.)<<,<,>,>>버튼 모두 삭제하였습니다.🎸기타
(관련 백엔드 api 변경 PR) 페이지네이션 처리 시 최대 다음 페이지 수를 5개로 제한 #902
아래와 같이 api 변경될 예정이라고 합니다.
(11/13 업데이트) paginationSizes로 변수명이 변경되었습니다.
🍗 PR 첫 리뷰 마감 기한
11/14 12:30