test: 피드백 키워드명 변경

woowacourse-teams · Nov 15, 2024 · 0c6e7d9 · 0c6e7d9
1 parent 3619723
commit 0c6e7d9
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 21 deletions.
diff --git a/backend/src/main/java/corea/ContextInitializer.java b/backend/src/main/java/corea/ContextInitializer.java
@@ -409,8 +409,8 @@ private void matchingAndReviewComplete(List<Participation> participations, Room
     }
 
     private void reviewSocialAndDevelopFeedback(MatchResult matchResult) {
-        socialFeedbackRepository.save(new SocialFeedback(matchResult.getRoomId(), matchResult.getReviewee(), matchResult.getReviewer(), 5, List.of(KIND, GOOD_AT_EXPLAINING), "너무 맘에 드는 말투이고, 설명이 친절했어요! 기회가 된다면 한번 더 리뷰 받고 싶어요~"));
-        developFeedbackRepository.save(new DevelopFeedback(matchResult.getRoomId(), matchResult.getReviewer(), matchResult.getReviewee(), 5, List.of(EASY_TO_UNDERSTAND_THE_CODE, MAKE_CODE_FOR_THE_PURPOSE), "코드를 이해하기 쉬워 리뷰하기 편했어요!~", 3));
+        socialFeedbackRepository.save(new SocialFeedback(matchResult.getRoomId(), matchResult.getReviewee(), matchResult.getReviewer(), 5, List.of(POSITIVE_SOCIAL_FEEDBACK_1, POSITIVE_SOCIAL_FEEDBACK_2), "너무 맘에 드는 말투이고, 설명이 친절했어요! 기회가 된다면 한번 더 리뷰 받고 싶어요~"));
+        developFeedbackRepository.save(new DevelopFeedback(matchResult.getRoomId(), matchResult.getReviewer(), matchResult.getReviewee(), 5, List.of(POSITIVE_DEVELOP_FEEDBACK_1, POSITIVE_DEVELOP_FEEDBACK_2), "코드를 이해하기 쉬워 리뷰하기 편했어요!~", 3));
         matchResult.reviewComplete();
         matchResult.reviewerCompleteFeedback();
         matchResult.revieweeCompleteFeedback();

diff --git a/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java b/backend/src/test/java/corea/feedback/domain/ReceivedFeedbacksTest.java
@@ -13,30 +13,30 @@ class ReceivedFeedbacksTest {
     @DisplayName("가장 많이 받은 긍정적인 피드백을 알 수 있다.")
     void findTopFeedbackKeywords1() {
         List<List<FeedbackKeyword>> developFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL, FeedbackKeyword.REVIEW_FAST),
-                List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL, FeedbackKeyword.REVIEW_FAST),
-                List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL),
-                List.of(FeedbackKeyword.KIND)
+                List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3),
+                List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3),
+                List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2),
+                List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1)
         );
         List<List<FeedbackKeyword>> socialFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE),
-                List.of(FeedbackKeyword.RESPONSE_FAST)
+                List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2),
+                List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_3)
         );
         ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords);
 
         List<String> result = receivedFeedbacks.findTopFeedbackKeywords(3);
 
-        assertThat(result).containsExactly("친절했어요", "매우 도움이 되었어요", "리뷰 속도가 빨랐어요");
+        assertThat(result).containsExactly("코드를 이해하기 쉬웠어요", "코드의 가독성이 뛰어나요", "코드가 일관성 있게 작성되어 있어요");
     }
 
     @Test
     @DisplayName("가장 많이 받은 긍정적인 피드백을 알 수 있다.")
     void findTopFeedbackKeywords2() {
         List<List<FeedbackKeyword>> developFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.KIND)
+                List.of(FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_1)
         );
         List<List<FeedbackKeyword>> socialFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.RESPONSE_SLOW, FeedbackKeyword.HARD_TO_UNDERSTAND_THE_CODE)
+                List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1)
         );
         ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords);
 
@@ -49,10 +49,10 @@ void findTopFeedbackKeywords2() {
     @DisplayName("긍정적인 피드백이 없다면 아무런 피드백도 반환하지 않는다.")
     void findTopFeedbackKeywords3() {
         List<List<FeedbackKeyword>> developFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.UNKIND, FeedbackKeyword.BAD_AT_EXPLAINING)
+                List.of(FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.NEGATIVE_DEVELOP_FEEDBACK_2)
         );
         List<List<FeedbackKeyword>> socialFeedbackKeywords = List.of(
-                List.of(FeedbackKeyword.NOT_MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.RESPONSE_SLOW)
+                List.of(FeedbackKeyword.NORMAL_SOCIAL_FEEDBACK_1, FeedbackKeyword.NEGATIVE_SOCIAL_FEEDBACK_2)
         );
         ReceivedFeedbacks receivedFeedbacks = new ReceivedFeedbacks(developFeedbackKeywords, socialFeedbackKeywords);
 

diff --git a/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java b/backend/src/test/java/corea/feedback/repository/DevelopFeedbackRepositoryTest.java
@@ -37,7 +37,7 @@ void findAllKeywordsByReceiverId() {
 
         Member deliver = memberRepository.save(MemberFixture.MEMBER_PORORO());
         Member receiver = memberRepository.save(MemberFixture.MEMBER_MOVIN());
-        List<FeedbackKeyword> feedbackKeywords = List.of(FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE, FeedbackKeyword.RESPONSE_FAST);
+        List<FeedbackKeyword> feedbackKeywords = List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2);
         DevelopFeedback feedback = new DevelopFeedback(room.getId(), deliver, receiver, 3, feedbackKeywords, "", 3);
         developFeedbackRepository.save(feedback);
 

diff --git a/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java b/backend/src/test/java/corea/feedback/repository/SocialFeedbackRepositoryTest.java
@@ -37,7 +37,7 @@ void findAllKeywordsByReceiverId() {
 
         Member deliver = memberRepository.save(MemberFixture.MEMBER_PORORO());
         Member receiver = memberRepository.save(MemberFixture.MEMBER_MOVIN());
-        List<FeedbackKeyword> feedbackKeywords = List.of(FeedbackKeyword.KIND, FeedbackKeyword.HELPFUL);
+        List<FeedbackKeyword> feedbackKeywords = List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2);
         SocialFeedback feedback = new SocialFeedback(room.getId(), deliver, receiver, 3, feedbackKeywords, "");
         socialFeedbackRepository.save(feedback);
 

diff --git a/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java b/backend/src/test/java/corea/feedback/service/UserFeedbackServiceTest.java
@@ -196,7 +196,7 @@ void getReceivedFeedback2() {
 
     private void saveRevieweeToReviewer(long roomId, Member reviewee, Member reviewer) {
         socialFeedbackRepository.save(
-                new SocialFeedback(null, roomId, reviewer, reviewee, 4, List.of(FeedbackKeyword.REVIEW_FAST, FeedbackKeyword.KIND), "유용한 정보들이 많았어요")
+                new SocialFeedback(null, roomId, reviewer, reviewee, 4, List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_4, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_1), "유용한 정보들이 많았어요")
         );
     }
 

diff --git a/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java b/backend/src/test/java/corea/fixture/DevelopFeedbackFixture.java
@@ -14,7 +14,7 @@ public static DevelopFeedback POSITIVE_FEEDBACK(long roomId, Member deliver, Mem
                 deliver,
                 receiver,
                 4,
-                List.of(FeedbackKeyword.HELPFUL, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE),
+                List.of(FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1, FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2),
                 "코드가 좋았어요",
                 2
         );

diff --git a/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java b/backend/src/test/java/corea/fixture/SocialFeedbackFixture.java
@@ -14,7 +14,7 @@ public static SocialFeedback POSITIVE_FEEDBACK(long roomId, Member deliver, Memb
                 deliver,
                 receiver,
                 4,
-                List.of(FeedbackKeyword.HELPFUL, FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE),
+                List.of(FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_3, FeedbackKeyword.POSITIVE_SOCIAL_FEEDBACK_2),
                 "코드가 좋았어요"
         );
     }

diff --git a/backend/src/test/java/corea/member/service/ProfileServiceTest.java b/backend/src/test/java/corea/member/service/ProfileServiceTest.java
@@ -60,9 +60,9 @@ void find_with_username() {
 
     private List<FeedbackKeyword> getFeedbackKeywords() {
         return List.of(
-                FeedbackKeyword.MAKE_CODE_FOR_THE_PURPOSE,
-                FeedbackKeyword.EASY_TO_UNDERSTAND_THE_CODE,
-                FeedbackKeyword.RESPONSE_FAST
+                FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_1,
+                FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_2,
+                FeedbackKeyword.POSITIVE_DEVELOP_FEEDBACK_3
         );
     }
 }