[BE] 랜덤 참여자들 가끔씩 5명만 보이는 문제 해결(#720) #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Test Results 61 files 61 suites 8s ⏱️ Results for commit c0af077. ♻️ This comment has been updated with latest results. |
youngsu5582
approved these changes
Nov 6, 2024
| return participationRepository.findAllByRoomId(roomId) | ||
| .stream() | ||
| .filter(participation -> isValidParticipant(participation, memberId)) | ||
| .collect(Collectors.toCollection(ArrayList::new)); |
| .orElse(null); | ||
| } | ||
|
|
||
| private RoomParticipantResponse toRoomParticipantResponse(MatchResult matchResult) { | ||
| return new RoomParticipantResponse( |
There was a problem hiding this comment.
이거 그냥 DTO 가 Participation 받아서 변환하게 하는건 안되나용?
There was a problem hiding this comment.
-> 이거 그냥 DTO 가 MatchResult 받아서 변환하게 하는건 안되나용?
이 말 맞죠??
그렇네요~ DTO가 변환하도록 수정합니다~ 👍👍
ashsty
approved these changes
Nov 7, 2024
| Room room = roomRepository.save(RoomFixture.ROOM_DOMAIN(manager)); | ||
| participationRepository.save(new Participation(room, manager, MemberRole.REVIEWER, ParticipationStatus.MANAGER, room.getMatchingSize())); | ||
| @Nested | ||
| @DisplayName("방에 참여한 사람들에 정보를 알 수 있다.") |
There was a problem hiding this comment.
ㅎㅎ
Suggested change
| @DisplayName("방에 참여한 사람들에 정보를 알 수 있다.") | |
| @DisplayName("방에 참여한 사람들의 정보를 알 수 있다.") |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋ 솔직히 저건 헷갈릴만 했다. 인정하시죠?
hjk0761
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
랜덤 참여자들이 한번씩 5명씩 보이는 문제를 해결했습니다.
기존 코드에서 limit() 함수가 filter()보다 먼저 호출되어, 필터링 조건에 맞지 않는 null 값이 포함된 상태에서 제한된 개수가 반환되는 문제가 있었습니다.
해결을 위해 filter()를 limit() 위로 위치를 변경했고, 이에 따른 수정 전후 테스트 기록을 커밋에 남겨두고 제거했습니다.
테스트 기록 (해결 된 후에는 굳이 남겨놓을 필요가 없다 생각들어 테스트 제거했습니다!)
또한, 기존 테스트 코드를 보완하여 본인, 리뷰어, pr 미제출자가 잘 제외가 되는지 테스트를 테스트 목적에 맞게 추가했습니다.