Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 모집중 이외의 방 클릭시에도 방 참여 알림이 보여지는 문제 해결(#754) #755

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2024

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

  • 모집중인 방 클릭시에만 알림창이 보이도록 수정
  • 방 생성 시 private 여부를 전송하도록 추가
KakaoTalk_Photo_2024-11-12-02-30-00

@github-actions github-actions bot added the FE 프론트 개발 관련 작업 label Nov 11, 2024
Copy link
Member

@00kang 00kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPrivate 속성으로 백과 연결작업까지 완료했군요!
수고하셨습니다~

Copy link
Contributor

@chlwlstlf chlwlstlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPrivate 속성 추가되면서 바뀐게 많네요..! 디자인 기본에서 바꿔주셔서 감사합니다😁😁

Comment on lines 92 to 98
/* 선택된 상태에서 스타일링 */
input:checked + &::before {
background-color: ${({ theme }) => theme.COLOR.primary2};
border-color: ${({ theme }) => theme.COLOR.primary2};
}

/* 체크된 상태에서 원 안의 점 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 남겨둔 이유가 있을까요??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 gpt 에서 받아온 코드 그대로 남겨놨네요,, ㅋㅋㅋㅋㅋ
저 주석은 지울게요!

@@ -12,7 +12,7 @@ import { RoomInfo } from "@/@types/roomInfo";
import { MAX_KEYWORDS } from "@/constants/room";
import { HoverStyledLink } from "@/styles/common";
import { theme } from "@/styles/theme";
import { convertdDayToKorean } from "@/utils/convertToKorean";
import { convertedDayToKorean } from "@/utils/convertToKorean";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타 변경 감사합니닷ㅎㅎ

@pp449 pp449 merged commit 1eed2aa into develop Nov 13, 2024
1 of 3 checks passed
@pp449 pp449 deleted the fix/#754 branch November 13, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트 개발 관련 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 모집중 이외의 방 클릭시에도 방 참여 알림이 보여지는 문제 해결
3 participants