-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 모집중 이외의 방 클릭시에도 방 참여 알림이 보여지는 문제 해결(#754) #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPrivate
속성으로 백과 연결작업까지 완료했군요!
수고하셨습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPrivate 속성 추가되면서 바뀐게 많네요..! 디자인 기본에서 바꿔주셔서 감사합니다😁😁
/* 선택된 상태에서 스타일링 */ | ||
input:checked + &::before { | ||
background-color: ${({ theme }) => theme.COLOR.primary2}; | ||
border-color: ${({ theme }) => theme.COLOR.primary2}; | ||
} | ||
|
||
/* 체크된 상태에서 원 안의 점 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주석 남겨둔 이유가 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 gpt 에서 받아온 코드 그대로 남겨놨네요,, ㅋㅋㅋㅋㅋ
저 주석은 지울게요!
@@ -12,7 +12,7 @@ import { RoomInfo } from "@/@types/roomInfo"; | |||
import { MAX_KEYWORDS } from "@/constants/room"; | |||
import { HoverStyledLink } from "@/styles/common"; | |||
import { theme } from "@/styles/theme"; | |||
import { convertdDayToKorean } from "@/utils/convertToKorean"; | |||
import { convertedDayToKorean } from "@/utils/convertToKorean"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타 변경 감사합니닷ㅎㅎ
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용