[FE] 리뷰 재촉 기능(#747) #757
Merged
[FE] 리뷰 재촉 기능(#747) #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pp449
requested changes
Nov 13, 2024
frontend/src/@types/alaram.ts
Outdated
| @@ -27,3 +29,8 @@ export interface AlarmAsRead { | |||
| alarmId: number; | |||
| alarmType: "USER"; | |||
| } | |||
|
|
|||
| export interface RevieweReminderAlarm { | |||
There was a problem hiding this comment.
여기 ReviewReminderAlarm 인데 오타인거 같네요!
| postReviewUrge({ roomId, reviewerId }), | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries({ | ||
| queryKey: [QUERY_KEYS.REVIEWERS, roomId, QUERY_KEYS.ALARM_COUNT, QUERY_KEYS.ALARM_LIST], |
There was a problem hiding this comment.
QUERY_KEYS.REVIEWERS, roomId, QUERY_KEYS.ALARM_COUNT, QUERY_KEYS.ALARM_LIST
각각의 key에 대한 invalidateQuery를 하려고 한것 같은데 이것은 결국 하나의 key 이기에 예상한대로 동작하지 않을거에요
queryClient.invalidateQueries({
queryKey: [QUERY_KEYS.REVIEWERS, roomId]
});
queryClient.invalidateQueries({
queryKey: [QUERY_KEYS.ALARM_COUNT]
});
queryClient.invalidateQueries({
queryKey: [QUERY_KEYS.ALARM_LIST]
});
이런식으로 각각에 대해 invalid 를 만들어줘야해요
There was a problem hiding this comment.
아하 이렇게 되면 의도한 동작이 아닐 수도 있군요!
수정했습니다~
chlwlstlf
approved these changes
Nov 13, 2024
frontend/src/constants/message.ts
Outdated
| @@ -42,6 +42,7 @@ const ERROR_MESSAGES = { | |||
| POST_REVIEW_COMPLETE: "코드리뷰 완료 요청에 실패했습니다.", | |||
| GET_MY_REVIEWERS: "리뷰어 목록을 불러오는 도중 에러가 발생하였습니다.", | |||
| GET_MY_REVIEWEES: "리뷰이 목록을 불러오는 도중 에러가 발생하였습니다.", | |||
| POST_REVIEW_URGE: "코드리뷰 재촉하기에 실패했습니다.", | |||
There was a problem hiding this comment.
Suggested change
| POST_REVIEW_URGE: "코드리뷰 재촉하기에 실패했습니다.", | |
| POST_REVIEW_URGE: "코드리뷰 재촉 요청에 실패했습니다.", |
코드리뷰 완료랑 비슷하게 이런 문구 어떤가요~~?
Comment on lines
29
to
31
| queryClient.invalidateQueries({ | ||
| queryKey: [QUERY_KEYS.REVIEWERS, roomId, QUERY_KEYS.ALARM_COUNT, QUERY_KEYS.ALARM_LIST], | ||
| }); |
There was a problem hiding this comment.
이렇게 되면 postReviewComplete 성공할 때도 ALARM_COUNT랑 ALARM_LIST를 invalidate 처리 해야할 것 같아요..!
There was a problem hiding this comment.
맞네용 이전 PR에서 놓쳤던 부분인데 짚어주셔서 감사합니다 :>
Comment on lines
+32
to
+33
| <span>{username}</span> 님이 <span>{info}</span> 미션에 대해 <span>코드리뷰를 완료</span> | ||
| 했습니다. |
There was a problem hiding this comment.
코드리뷰 완료도 굵게 처리 되었으면 좋겠다고 피드백이 들어 왔었는데 바로 반영해주셨네요👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용