Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 방 참여 조건에 대한 모달 변경(#758) #759

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2024

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

  • 방 참여 조건을 보여주는 alert을 처음 카드 컴포넌트를 클릭했을 때 보여주는게 아닌 참여하기 버튼 클릭 시 보여주도록 변경
  • 해당 alert 모달을 confirm 모달로 변경
Screen.Recording.2024-11-12.at.11.14.56.PM.mov

@github-actions github-actions bot added the FE 프론트 개발 관련 작업 label Nov 12, 2024
Copy link
Member

@00kang 00kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요구사항에 맞춰 계속 수정하느라고 고생이 많습니다 🥲
확인 완료!

Copy link
Contributor

@chlwlstlf chlwlstlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정책이 안 정해져서 코드가 계속 바뀌네요.. 다르 수고했습니다😊😊😊
createPortal인데 모달 두 개 뜨는 게 신기해서 확인해봤더니 #modal 안에 중첩으로 계속 들어가는 군요???? 신기한거 알아갑니다ㅎㅎㅎ
image

Comment on lines +70 to +75
<ConfirmModal
isOpen={isNoticeModalOpen}
onClose={handleNoticeModal}
onConfirm={handleParticipateRoomClick}
onCancel={handleNoticeModal}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

취소가 생기면서 confirmModal로 바꿨군요! 좋습니당👍👍

@chlwlstlf chlwlstlf merged commit 722a6dd into develop Nov 13, 2024
3 checks passed
@chlwlstlf chlwlstlf deleted the feat/#758 branch November 13, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트 개발 관련 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 방 참여 조건에 대한 모달 변경
3 participants