[BE] feat: 로그아웃 api 구현 #1121
Merged
[BE] feat: 로그아웃 api 구현 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayonsoso
commented
Feb 16, 2025
Comment on lines
+53
to
+63
| HttpSession session = httpRequest.getSession(false); | ||
| if (session != null) { | ||
| session.invalidate(); | ||
| } | ||
|
|
||
| ResponseCookie cookie = ResponseCookie.from("JSESSIONID", "") | ||
| .path("/") | ||
| .maxAge(0) | ||
| .secure(true) | ||
| .httpOnly(true) | ||
| .build(); |
There was a problem hiding this comment.
🔥 어떻게 해결했나요 ?
1/ 서버에 저장되어있는 세션을 비활성화합니다.
2/ set-cookie 를 통해서 브라우저에 저장되어있는 쿠키까지 삭제합니다.
Comment on lines
+55
to
+56
| .statusCode(204) | ||
| .header("Set-Cookie", containsString("JSESSIONID=; Path=/; Max-Age=0")); |
There was a problem hiding this comment.
테스트 코드에서 set cookie 로 브라우저의 쿠키를 삭제하는 것을 테스트하게 합니다.
Kimprodp
approved these changes
Feb 17, 2025
| sessionManager.saveReviewRequestCode(session, reviewRequestCode); | ||
| return ResponseEntity.noContent().build(); | ||
| } | ||
|
|
||
| @PostMapping("/v2/auth/logout") | ||
| public ResponseEntity<Void> logout( | ||
| HttpServletRequest httpRequest | ||
| HttpServletRequest httpRequest, | ||
| HttpServletResponse response |
There was a problem hiding this comment.
response 사용되지 않는데, 제거해도 되지 않을까요?
# Conflicts: # backend/src/main/java/reviewme/auth/controller/AuthController.java # backend/src/test/java/reviewme/api/AuthApiTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?