Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[사전 미션 - 워밍업] - 파슬리(김윤아) 미션 제출합니다. #25

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[사전 미션 - 워밍업] - 파슬리(김윤아) 미션 제출합니다. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc3c0ad
refactor: index.html 언어 설정 변경
anttiey Sep 23, 2024
4760472
refactor: 버튼에 적절한 type, aria-label 추가
anttiey Sep 23, 2024
41d248e
refactor: 스크린 리더가 변화를 인식하도록 aria-live 추가
anttiey Sep 23, 2024
b422068
refactor: 스크린 리더를 위한 에러 메시지 추가
anttiey Sep 23, 2024
1c7e46c
refactor: 시멘틱 태그로 변경
anttiey Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions a11y/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
<!doctype html>
<html lang="en">

<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Accessibility</title>
</head>

<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
<!DOCTYPE html>
<html lang="ko-KR">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Accessibility</title>
</head>

<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
14 changes: 7 additions & 7 deletions a11y/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import "./Typography.css";
import "./App.css";
import './Typography.css';
import './App.css';

import FlightBooking from "./components/FlightBooking";
import FlightBooking from './components/FlightBooking';

function App() {
return (
<div className="app">
<div className="app-main">
<div className="flight-booking-container">
<main className="app-main">
<section className="flight-booking-container">
<FlightBooking />
</div>
</div>
</section>
</main>
</div>
);
}
Expand Down
13 changes: 12 additions & 1 deletion a11y/src/components/FlightBooking.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
width: 30px;
height: 30px;
border-radius: 16px;
border: 1px solid #C0C0C0;
border: 1px solid #c0c0c0;
background-color: #fff;
cursor: pointer;
display: flex;
Expand All @@ -61,3 +61,14 @@
border-radius: 4px;
cursor: pointer;
}

.visually-hidden {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
border: 0;
}
36 changes: 31 additions & 5 deletions a11y/src/components/FlightBooking.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,28 @@
import { useState } from "react";
import { useState } from 'react';

import "./FlightBooking.css";
import './FlightBooking.css';

const MAX_PASSENGERS = 3;

const FlightBooking = () => {
const [adultCount, setAdultCount] = useState(1);
const [errorMessage, setErrorMessage] = useState('');

const incrementCount = () => {
if (adultCount === MAX_PASSENGERS) {
setErrorMessage('최대 인원에 도달했습니다.');
return;
}

setAdultCount((prev) => Math.min(MAX_PASSENGERS, prev + 1));
};

const decrementCount = () => {
if (adultCount === 1) {
setErrorMessage('최소 1명의 승객이 필요합니다.');
return;
}

setAdultCount((prev) => Math.max(1, prev - 1));
};

Expand All @@ -20,15 +31,30 @@ const FlightBooking = () => {
<h2 className="heading-2-text">항공권 예매</h2>
<div className="passenger-count">
<span className="body-text">성인</span>
<div className="counter">
<button className="button-text" onClick={decrementCount}>
<div className="counter" aria-live="polite">
<button
type="button"
className="button-text"
onClick={decrementCount}
aria-label="성인 승객 감소"
>
-
</button>
<span>{adultCount}</span>
<button className="button-text" onClick={incrementCount}>
<button
type="button"
className="button-text"
onClick={incrementCount}
aria-label="성인 승객 증가"
>
+
</button>
</div>
{errorMessage && (
<div aria-live="assertive" role="alert" className="visually-hidden">
{errorMessage}
</div>
)}
</div>
<button className="search-button">항공편 검색</button>
</div>
Expand Down