-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Send editor feedback #21586
feat: Send editor feedback #21586
Conversation
Collecting feedback from users while in editor may uncover valuable insights.
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21586 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
In the context of displaying the send feedback form in the editor, merely navigating backwards meant the editor would be displayed, not the expected help screen.
WordPress/src/main/java/org/wordpress/android/ui/main/feedbackform/FeedbackFormActivity.kt
Show resolved
Hide resolved
@dcalhoun This works well, but I'm wondering if we need to include something that tells us the feedback was sent from the editor? Perhaps something as simple as adding "Editor feedback: " to the beginning of the feedback text? |
Yeah, I think that is a good idea. I'll explore flagging the feedback, with a prefix or otherwise. |
Indicate the context for feedback submissions originating from the editor.
@nbradbury I added an |
Quality Gate passedIssues Measures |
I think that's fine! I'll approve this and leave it to you to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collecting feedback from users while in editor may uncover valuable
insights.
Related:
To Test:
Regression Notes
None likely with this limited addition.
N/A
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):