Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send editor feedback #21586

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: Send editor feedback #21586

merged 4 commits into from
Jan 16, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 15, 2025

Collecting feedback from users while in editor may uncover valuable
insights.

Related:

To Test:

  1. Open the experimentla editor.
  2. Tap the more button (three vertical dots) in the top-right corner.
  3. Tap Send Feedback.
  4. Submit feedback.
  5. Verify its delivery within the customer support system.

Regression Notes

  1. Potential unintended areas of impact
    None likely with this limited addition.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A
  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Collecting feedback from users while in editor may uncover valuable
insights.
@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jan 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 15, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21586-f4bde50
Commitf4bde50
Direct Downloadjetpack-prototype-build-pr21586-f4bde50.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21586-f4bde50
Commitf4bde50
Direct Downloadwordpress-prototype-build-pr21586-f4bde50.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.48%. Comparing base (e72074a) to head (f4bde50).
Report is 62 commits behind head on trunk.

Files with missing lines Patch % Lines
...ava/org/wordpress/android/ui/ActivityLauncher.java 0.00% 3 Missing ⚠️
...roid/ui/main/feedbackform/FeedbackFormViewModel.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21586   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In the context of displaying the send feedback form in the editor,
merely navigating backwards meant the editor would be displayed, not the
expected help screen.
@dcalhoun dcalhoun marked this pull request as ready for review January 15, 2025 20:02
@dcalhoun dcalhoun requested a review from nbradbury January 15, 2025 20:03
@nbradbury nbradbury self-assigned this Jan 15, 2025
@nbradbury
Copy link
Contributor

@dcalhoun This works well, but I'm wondering if we need to include something that tells us the feedback was sent from the editor? Perhaps something as simple as adding "Editor feedback: " to the beginning of the feedback text?

@dcalhoun
Copy link
Member Author

This works well, but I'm wondering if we need to include something that tells us the feedback was sent from the editor? Perhaps something as simple as adding "Editor feedback: " to the beginning of the feedback text?

Yeah, I think that is a good idea. I'll explore flagging the feedback, with a prefix or otherwise.

Indicate the context for feedback submissions originating from the
editor.
@dcalhoun
Copy link
Member Author

@nbradbury I added an [Editor] prefix for feedback submitted from within the editor in f4bde50. Let me know what you think of the prefix and implementation. Thanks!

@nbradbury
Copy link
Contributor

I added an [Editor] prefix for feedback submitted from within the editor

I think that's fine! I'll approve this and leave it to you to merge.

Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dcalhoun dcalhoun merged commit e69c9d8 into trunk Jan 16, 2025
22 checks passed
@dcalhoun dcalhoun deleted the feat/send-editor-feedback branch January 16, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants