Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UsingMaterialAndMaterial3Libraries from lint #21591

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Remove UsingMaterialAndMaterial3Libraries from lint #21591

merged 1 commit into from
Jan 17, 2025

Conversation

nbradbury
Copy link
Contributor

Fixes #21590

As per the comment here:

About switching from warning to error, just because this UsingMaterialAndMaterial3Libraries check is of Warning severity by default, but we are anyway treating all warning as errors (WordPress/build.gradle#L317), I would recommend deleting this whole configuration and its comment (#21065), doing that we will end-up with the same result.

This PR addresses this issue.

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 16, 2025 •
edited
Loading

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nbradbury nbradbury added the Material3 Related to updating to Material 3 label Jan 16, 2025
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21591-51a7200
Commit51a7200
Direct Downloadwordpress-prototype-build-pr21591-51a7200.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21591-51a7200
Commit51a7200
Direct Downloadjetpack-prototype-build-pr21591-51a7200.apk
 Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review January 16, 2025 11:03
@nbradbury nbradbury requested a review from ParaskP7 January 16, 2025 17:17
ParaskP7
ParaskP7 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @nbradbury , thanks so much for applying this suggestion! 🥇

@nbradbury nbradbury merged commit c0a576e into trunk Jan 17, 2025
24 checks passed
@nbradbury nbradbury deleted the issue/21590-material3-lint branch January 17, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

Assignees
No one assigned
Labels
Material3 Related to updating to Material 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove UsingMaterialAndMaterial3Libraries from lint
4 participants
@nbradbury @dangermattic @wpmobilebot @ParaskP7