Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack pre-publishing: use correct colors in categories and tags #21593

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

nbradbury
Copy link
Contributor

Fixes #21592

As noted in the issue, prior to this PR the categories and tags bottom sheets used the WordPress colors in the Jetpack app's pre-publishing bottom sheets. This PR resolves this.

To test:

  • Edit a post
  • Tap Update
  • Tap Categories
  • Tap + to add a category
  • Note that the app uses the correct colors
  • Return to the post
  • Tap Update
  • Tap Tags
  • Note that the app uses the correct colors

Jetpack

jetpack

WordPress

wordpress

@nbradbury nbradbury added the Material3 Related to updating to Material 3 label Jan 16, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 16, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 16, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21593-9fecf75
Commit9fecf75
Direct Downloadwordpress-prototype-build-pr21593-9fecf75.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 16, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21593-9fecf75
Commit9fecf75
Direct Downloadjetpack-prototype-build-pr21593-9fecf75.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review January 16, 2025 13:32
@nbradbury nbradbury requested a review from dcalhoun January 16, 2025 13:32
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the expected color was used within tags, categories, and post settings—for each of the Jetpack and WordPress app. 🎉

Thanks for addressing this oddity.

@nbradbury nbradbury merged commit ddb6226 into trunk Jan 16, 2025
22 checks passed
@nbradbury nbradbury deleted the issue/21592-use-jp-colors branch January 16, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Material3 Related to updating to Material 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP color used instead of JP color in pre-publishing
4 participants