-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Android 15 #21599
Update to Android 15 #21599
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21599 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @nbradbury !
I have reviewed and tested this PR as per the instructions, everything works as expected, great job wit this compileSdkVersion
update! 🌟 x 🌟 ^ 🌟
FYI: Also, I put some extra focus on the WindowExtensions.kt
changes, identified usages of both setWindowStatusBarColor(...)
and setWindowNavigationBarColor(...)
, which weren't many anyway:
ReaderPostDetailFragment
ReaderReadingPreferencesDialogFragment
SupportWebViewActivity
DialogExtensions -> Dialog.setStatusBarAsSurfaceColor
And then tried testing those, see if I can see any diff. In the end, everything looked good to me when testing on both, 15 or older devices.
I have left just one question (❓) and a few suggestion (💡) comments for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.
PS: Having said that, I recommend for someone closer to JP/WPAndroid to go for another pass at this, do some more testing, maybe be more thorough than me, just in case I missed something obvious.
WordPress/src/main/java/org/wordpress/android/support/SupportWebViewActivity.kt
Show resolved
Hide resolved
...in/java/org/wordpress/android/ui/mysite/cards/quicklinksitem/QuickLinksItemViewModelSlice.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/util/extensions/WindowExtensions.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/util/signature/SignatureUtils.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes on two Android emulators—SDK 35 and 30—I did not note any visual regressions. 🚀
Quality Gate passedIssues Measures |
Closes #21596
This PR updates our app to Android 15, as has already been done for WCAndroid - p91TBi-cHS-p2. The following items have been addressed:
compileSdkVersion
to 35WindowExtensions
to remove unused or deprecated featuresWordPressDebug
to KotlinStrictMode
and updated it to includedetectNonSdkApiUsage
. This is for my testing purposes only - I'll disable it before this branch is merged.Note that I left
targetSdkVersion
at 34 because targeting 35 causes the app to default to edge-to-edge, which leads to a number of overlapping problems. We can revisit this at a later date.To test: