Adds fetch all-domains api call #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 11, 2023 14:43
…ll-domains response
justtwago
approved these changes
Oct 11, 2023
example/src/test/java/org/wordpress/android/fluxc/network/rest/wpcom/site/SiteRestClientTest.kt
Outdated
Show resolved
Hide resolved
| @@ -561,6 +584,13 @@ class SiteRestClientTest { | |||
| return initGetResponse(SitesFeaturesRestResponse::class.java, data ?: mock(), error) | |||
| } | |||
|
|
|||
| private suspend fun initAllDomainsResponse( | |||
| data: AllDomainsResponse? = null, | |||
| error: WPComGsonNetworkError? = null | |||
There was a problem hiding this comment.
Optional nitpick: the property is never used. If we don't want to test the error cases for the "fetch all domains" flow, we can remove it and pass null directly, or we can have a test for a bad case too. What do you think?
There was a problem hiding this comment.
Thank you for catching this @justtwago 🙇
I've added some tests for the error cases with 5bed1ee
Co-authored-by: Artyom Vlasov <[email protected]>
justtwago
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of wordpress-mobile/WordPress-Android#19165
This PR adds the ability to fetch all domains for the logged in user.
Note: For simplicity and given that the domains management feature will use the existing fetchSiteDomains call I decided to add the new call in the
SiteStorethough it is not directly related to the current site.To test: