Observe blaze campaigns #2871
Merged
Observe blaze campaigns #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
commented
Oct 16, 2023
| @Transaction | ||
| @Query("SELECT * from BlazeCampaigns WHERE `siteId` = :siteId ORDER BY createdAt DESC") | ||
| fun getMostRecentCampaignForSite(siteId: Long): BlazeCampaignModel? { | ||
| return getCampaigns(siteId)?.firstOrNull()?.toDomainModel() |
There was a problem hiding this comment.
This implementation wasn't optimal, it loaded the whole campaigns list just to take the first one, I updated to use a pure SQLite implementation.
hichamboushaba
force-pushed
the
observe-blaze-campaigns
branch
from
c2d34a2 to
0eff506
Compare
Merged
1 task
JorgeMucientes
approved these changes
Oct 17, 2023
|
Code looks good! Thanks for exposing an observable 👍🏼. I'll definitely be using that for the campaign list screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for observing DB changes related to the Blaze Campaigns.
No testing is required, it will be tested as part of the WCAndroid PRs.