Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SiteModel: Add column isSingleUserSite #2873

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Update SiteModel: Add column isSingleUserSite #2873

merged 8 commits into from
Oct 18, 2023

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Oct 17, 2023 •
edited
Loading

This PR adds a new column to SiteModel called isSingleUserSite which represents (bool) Whether the site is single user. Only returned for [WP.com](http://wp.com/) sites and for Jetpack sites with version 3.4 or higher (taken from rest api endpoint).

See WP Companion wordpress-mobile/WordPress-Android#19404 for testing instructions.

Updates include:

  • New column in SiteModel
  • Update db version
  • Add migration alter SQL statement
  • Update site_fields to request the single_user_site in the fetch sites API request

@zwarm zwarm requested a review from AjeshRPai October 17, 2023 20:12
@zwarm zwarm self-assigned this Oct 17, 2023
@zwarm zwarm mentioned this pull request Oct 17, 2023
Merged
3 tasks
@zwarm zwarm marked this pull request as ready for review October 17, 2023 22:19
@zwarm zwarm mentioned this pull request Oct 17, 2023
Closed
AjeshRPai
AjeshRPai approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the companion PR as per the instructions, everything loos good

@AjeshRPai AjeshRPai merged commit fbfd145 into trunk Oct 18, 2023
2 checks passed
@AjeshRPai AjeshRPai deleted the issue/add-singleusersite-to-sitemodel branch October 18, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AjeshRPai AjeshRPai AjeshRPai approved these changes

Assignees

@zwarm zwarm

Labels
[Store] Site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwarm @AjeshRPai