[Woo POS][non-simple products] Remove empty filters condition from deleting stale products from database #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnirudhBhat
changed the title
4 tasks
samiuelson
approved these changes
Nov 28, 2024
| @@ -1604,8 +1604,7 @@ class WCProductStore @Inject constructor( | |||
| if (forceRefresh && | |||
| offset == 0 && | |||
| includedProductIds.isEmpty() && | |||
| excludedProductIds.isEmpty() && | |||
| filterOptions.isEmpty() | |||
| excludedProductIds.isEmpty() | |||
There was a problem hiding this comment.
❓ Does it affect the Product screen in store management?
There was a problem hiding this comment.
Yes and no.
Yes, because we have removed filterOptions.isEmpty() condition that was a requirement earlier before we deleted products.
No, because AFAIU, there will not be any behavioural changes in the products screen because of this. When we apply any filter on the products screen and pull to refresh, we delete and then upsert products now instead of just upserting product.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the corresponding WooCommerce PR after reviewing and merging this one
This PR removes empty filter condition which was one among few conditions we were checking before removing stale products from the database before inserting new ones fetched from the remote.
This was done since for POS, when we fetch products, there always will be filter applied for products (simple + variable) unless we support all types of products in POS. Since from POS, we won't be having an empty filter, the stale products in the database weren't being removed.