Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Dagger version to latest one. #85

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Updates Dagger version to latest one. #85

merged 1 commit into from
Jan 28, 2025

Conversation

JorgeMucientes
Copy link
Contributor

@JorgeMucientes JorgeMucientes commented Jan 28, 2025

This PR updates the Dagger version to 2.55.

This update is needed to be able to upgrade Dagger version in client app of Media Picker. We found out that if Dagger is updated in the client app to a version above 2.51, but Media picker library doesn't update Dagger, then MediaPickerViewModel will crash when attempting to instantiate it. More context here.

There's not much to be tested here. Only that all the checks pass. Going over the test instructions from this PR should be enough to ensure nothing is broken.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in woocommerce/woocommerce-android#13402. LGTM! 👍🏻

@irfano irfano merged commit d6daa7a into trunk Jan 28, 2025
13 checks passed
@irfano irfano deleted the update-dagger-dep branch January 28, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants