Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullability Annotations to Java Classes] Update wordPressLintVersion to 2.0.0 #136

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[Nullability Annotations to Java Classes] Update wordPressLintVersion to 2.0.0 #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ext {

ext {
// libs
wordpressLintVersion = '1.1.0'
wordpressLintVersion = '2.0.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: why don't we need to exclude generated files, like we did in WordPress-Android repository? https://github.com/wordpress-mobile/WordPress-Android/pull/19434/files#diff-e8b41fbc109de9b7fa37c43933345e6050e96b3c94fd279696d2adbfb9a90d38R25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question @wzieba ! 💯

Please follow this response comment of mine to understand the why. 🙏

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha, thanks!


// main
androidxCoreVersion = '1.5.0'
Expand Down