Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Xcode report concurrency warnings on the Modules package #23838

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

This PR will introduce about 100+ more warnings. I'll "address" (probably just @unchecked Sendable) them in follow up PRs.

As the warnings gone, I'll remove the compiler flags, which means compiler will report errors if new code violates concurrency rules.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is assigned to the milestone 25.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23838-c38b7e5
Version25.4.2
Bundle IDorg.wordpress.alpha
Commitc38b7e5
App Center BuildWPiOS - One-Offs #11094
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23838-c38b7e5
Version25.4.2
Bundle IDcom.jetpack.alpha
Commitc38b7e5
App Center Buildjetpack-installable-builds #10134
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
Copy link
Contributor

kean commented Nov 20, 2024

Apple recommends to work in waves: enable the flags, fix some issues, disable the flags. Continue until there are no more warnings/errors and the flags can be enabled permanently.

@crazytonyli
Copy link
Contributor Author

crazytonyli commented Nov 21, 2024

@kean I thought enabling the concurrency checks (with errors) earlier would be nice, especially considering we have added @unchecked Sendable everywhere (in #23527) to ignore the concurrency check warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants