Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swipe to dismiss GutenbergKit keyboard #24010

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 23, 2025

Allow dismissing the virtual keyboard within the GutenbergKit editor. Supersedes #23988.

Related:

To test: See wordpress-mobile/GutenbergKit#63.

Regression Notes

  1. Potential unintended areas of impact
    None likely given single dependency update.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun dcalhoun added Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement labels Jan 23, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 23, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 23, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24010-e1bded3
Version25.7
Bundle IDorg.wordpress.alpha
Commite1bded3
App Center BuildWPiOS - One-Offs #11396
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 23, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24010-e1bded3
Version25.7
Bundle IDcom.jetpack.alpha
Commite1bded3
App Center Buildjetpack-installable-builds #10428
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun mentioned this pull request Jan 23, 2025
14 tasks
@dcalhoun dcalhoun marked this pull request as ready for review January 23, 2025 15:48
@dcalhoun dcalhoun requested a review from kean January 23, 2025 15:48
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great, love it. I personally like it more than the current prod.

@dcalhoun dcalhoun enabled auto-merge January 23, 2025 19:05
@dcalhoun dcalhoun force-pushed the feat/gutenberg-kit-swipe-to-dismiss-keyboard branch from 10d5ae1 to e1bded3 Compare January 24, 2025 20:14
@dcalhoun dcalhoun added this pull request to the merge queue Jan 24, 2025
Merged via the queue into trunk with commit b9a0dea Jan 24, 2025
25 checks passed
@dcalhoun dcalhoun deleted the feat/gutenberg-kit-swipe-to-dismiss-keyboard branch January 24, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants