Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP – Fix build.gradle for Android checks and version bump #556

Closed
wants to merge 7 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 6, 2024

What does it do?

I run into this when working on the Simplenote Android 2.32 code freeze.

I run the 2.31 code freeze using 9.1.0 (see Automattic/simplenote-android#1631) and it worked fine. Since then, the project upgraded to 9.4.0 via Automattic/simplenote-android#1636 and the lane gives errors related the code implicitly expecting a version.properties parameter.

I started addressing them, by ensuring the code uses build.gradle when version.properties is not given. But the more I progressed the more I questioned the value of the work I was doing. _Wouldn't it be better to support only the version.properties only, so that code and tests can be clearer?

I then run into this error, which looks to me like a mix of the setup expecting an alpha that is not there without a way to opt-out and dead code still lingering in release-toolkit:

image
image

I decided to push this PR as draft for reference and to raise the approach question with the team.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Please add an entry in the CHANGELOG.md file to describe the changes made by this PR
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@mokagio
Copy link
Contributor Author

mokagio commented Aug 8, 2024

Closing in favor of #579 #580

@mokagio mokagio closed this Aug 8, 2024
@mokagio mokagio deleted the mokagio/add-missing-gradle-param branch August 19, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants