WIP – Fix build.gradle
for Android checks and version bump
#556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I run into this when working on the Simplenote Android 2.32 code freeze.
I run the 2.31 code freeze using 9.1.0 (see Automattic/simplenote-android#1631) and it worked fine. Since then, the project upgraded to 9.4.0 via Automattic/simplenote-android#1636 and the lane gives errors related the code implicitly expecting a
version.properties
parameter.I started addressing them, by ensuring the code uses
build.gradle
whenversion.properties
is not given. But the more I progressed the more I questioned the value of the work I was doing. _Wouldn't it be better to support only theversion.properties
only, so that code and tests can be clearer?I then run into this error, which looks to me like a mix of the setup expecting an alpha that is not there without a way to opt-out and dead code still lingering in
release-toolkit
:I decided to push this PR as draft for reference and to raise the approach question with the team.
Checklist before requesting a review
bundle exec rubocop
to test for code style violations and recommendationsspecs/*_spec.rb
) if applicablebundle exec rspec
to run the whole test suite and ensure all your tests passCHANGELOG.md
file to describe your changes under the appropriate existing###
subsection of the existing## Trunk
section.MIGRATION.md
file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.