Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other_action to git_submodule_update call #561

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

spencertransier
Copy link
Contributor

@spencertransier spencertransier commented Apr 12, 2024

What does it do?

This PR adds other.action. to the git_submodule_update call in the android_download_translations action. This was a bug reported by @ashiagr in p1712924182271989-slack-CC7L49W13:

screenshot_2024-04-12_at_5 44 13_pm

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 12, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@spencertransier spencertransier requested a review from a team April 12, 2024 14:29
@spencertransier spencertransier marked this pull request as ready for review April 12, 2024 14:31
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in pocket-casts-android repo by:

  • Pointing the release-toolkit to this PR's branch in the Gemfile, then bundle install
  • Commenting everything except the call to android_download_translations in the finalize_release lane
  • Run the lane
  • Confirm that, after downloading the translations, the logs shows that git submodule update --init --recursive has been called, and the gradle lint task is called afterwards

@spencertransier spencertransier merged commit e99aea3 into trunk Apr 15, 2024
8 checks passed
@spencertransier spencertransier deleted the fix/git_submodule_update_call branch April 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants