Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 'Menu' demo to Vala #172

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

BharatAtbrat
Copy link
Contributor

Added Vala code for Menu

Let me know if there are any issues with the code!

Add Vala code for Menu
src/Menu/main.vala Outdated Show resolved Hide resolved
src/Menu/main.vala Outdated Show resolved Hide resolved
src/Menu/main.vala Outdated Show resolved Hide resolved
src/Menu/main.vala Outdated Show resolved Hide resolved
src/Menu/main.vala Outdated Show resolved Hide resolved
src/Menu/main.vala Outdated Show resolved Hide resolved
Remove unnecessary package declarations
Omit use of "GLib"
Add checks for null (can be returned by state.lookup)
Replace Gtk.StringList with GenericArray<string>
Use foreach to append attr_string
Changes as suggested by @Diego-Ivan
@BharatAtbrat BharatAtbrat requested a review from Diego-Ivan June 13, 2024 07:46
Copy link
Contributor

@Diego-Ivan Diego-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonnyp sonnyp merged commit 9dad1c3 into workbenchdev:main Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants