Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 'Scrolled Window' demo to Vala #178

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

BharatAtbrat
Copy link
Contributor

Added initial Vala code for Scrolled Window

Let me know if there are any issues with the implementation

Add initial Vala code for Scrolled Window
Copy link
Contributor

@Diego-Ivan Diego-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

src/Scrolled Window/main.vala Outdated Show resolved Hide resolved
Use key iteration against foreach method of Hashtable
@BharatAtbrat BharatAtbrat requested a review from Diego-Ivan June 15, 2024 06:49
Copy link
Contributor

@Diego-Ivan Diego-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonnyp sonnyp merged commit bb5df9b into workbenchdev:main Jun 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants