Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Audio demo #193

Merged
merged 3 commits into from
Aug 5, 2024
Merged

[Rust] Audio demo #193

merged 3 commits into from
Aug 5, 2024

Conversation

ondrejkolin
Copy link
Contributor

No description provided.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, apart from that it looks good!

src/Audio/code.rs Outdated Show resolved Hide resolved
}

controls.set_media_stream(Some(&gtk::MediaFile::for_file(
&gtk::gio::File::for_uri(&workbench::resolve(file_name))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always bring glib and gio into scope if you use them

@ondrejkolin
Copy link
Contributor Author

I think I've fixed this one ... I'll update the other ones too...

@ondrejkolin
Copy link
Contributor Author

Thanks for the hints I've updated all the PRs

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hofer-Julian Hofer-Julian merged commit 9bfd2be into workbenchdev:main Aug 5, 2024
1 check failed
@ondrejkolin ondrejkolin deleted the Audio branch August 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants