Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Port the ListView demo #198

Merged
merged 11 commits into from
Aug 6, 2024
Merged

[Rust] Port the ListView demo #198

merged 11 commits into from
Aug 6, 2024

Conversation

ondrejkolin
Copy link
Contributor

I am not sure if I should put those comments into the code...

Hofer-Julian
Hofer-Julian reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

Your comments are fine by me

src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
Hofer-Julian
Hofer-Julian reviewed Aug 6, 2024
View reviewed changes
src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
ondrejkolin and others added 6 commits August 6, 2024 09:37
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
afe3da0 
Fix the language

Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
6555ed3 
Missed this one glib::clone

Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
24d9dbb 
Fixed comment

Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
ad120f6 
English too hard

Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
976a390 
Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin @Hofer-Julian
Update src/List View/code.rs
981a3c3 
Remove unnecessary debugging output

Co-authored-by: Hofer-Julian <[email protected]>
@ondrejkolin
Copy link
Contributor Author

@ondrejkolin btw. the position: {}, Item removed? {}, Item added? {} differs from the other languages... Is that because the model is immutable in rust?

Hofer-Julian
Hofer-Julian reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. the position: {}, Item removed? {}, Item added? {} differs from the other languages... Is that because the model is immutable in rust?

Good that you mention that, there was indeed a subtle bug :D

Also, please rename strings_model to string_model

src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
src/List View/code.rs Outdated Show resolved Hide resolved
@Hofer-Julian Hofer-Julian merged commit be31107 into workbenchdev:main Aug 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrejkolin @Hofer-Julian