Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Camera tools #209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bgruening
Copy link
Contributor

@bgruening bgruening commented Oct 30, 2021

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

This PR cleans up the camera tools. It's:

  • removing the external datatypes, which are shipped with Galaxy now.
  • add missing single quotes
  • annotates the R scripts to make this tool work in pulsar
  • adds argument and unifies the parameter help section


]]> </command>
<required_files>
<include path="lib.r" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed, because Galaxy does not know that lib.r belongs to the tool. CAMERA_combinexsAnnos.r can be deduced from the command section, but lib.r not. This feature is new and needs the 21.09 Galaxy release.
The advantage is that it will make this tool for in pulsar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know!

@lecorguille
Copy link
Member

Do we need to update planemo or something ?

@bgruening
Copy link
Contributor Author

Oh yes, probably. I will see if I find time for that. Is the rest fine with you?

@lecorguille
Copy link
Member

Sure all good for me!
Thanks

I will have to apply the same <required_files> to many other tools

@hechth
Copy link
Contributor

hechth commented Jun 23, 2023

@Lain-inrae what would be needed to revive and merge this PR? I think getting CAMERA and such tools back up to date would be great :) or @yguitton is this already outdated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants