Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/BE-42-applicant-change-password #181

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

AAnakhe
Copy link
Collaborator

@AAnakhe AAnakhe commented Nov 25, 2022

issue

  • As a professional or developer, I should be able to change my password

what has changed

  • The repository layer has a PasswordJpaRepository interface that extends JpaRepository.

  • The service layer has a ChangePasswordService interface and a ChangePasswordServiceImpl class that implements the
    checkIfValidOldPassword and changePassword method.

  • The controller layer has a ChangePasswordController class with a changePassword method that returns JSON of the updated password.

Linear link: https://linear.app/team-hydraulics/issue/BAC-86/applicant-change-password

@gitguardian
Copy link

gitguardian bot commented Nov 26, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
5101767 SMTP credentials cb8d62e Apply-For-Me-Api/src/main/resources/application.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant