Feat/be 120 applicant view details #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jayhmz
reviewed
Dec 4, 2022
| @RequestParam(value = "pageNo", defaultValue = DEFAULT_PAGE_NUMBER, required = false) int pageNo, | ||
| @RequestParam(value = "pageSize", defaultValue = DEFAULT_PAGE_SIZE, required = false) int pageSize, | ||
| @RequestParam(value = "sortBy", defaultValue = DEFAULT_SORT_BY, required = false) String sortBy, | ||
| @RequestParam(value = "sortDir", defaultValue = DEFAULT_SORT_DIRECTION, required = false) String sortDir) { |
There was a problem hiding this comment.
remove the id in the url, we do not need to specify the id of an existing user, instead we fetch the user from the security context. so use the security context to get the id of the user and pass that into the service method
There was a problem hiding this comment.
I've implemented that and it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As an applicant, I should be able to see my personal details
What has changed
Created an Applicant Repository, Service and Controller to implement my methods for an applicant to view his/her details
Used CurrentUserUtil.getCurrentUser() method to get the details of the current user
Link to linear ticket: https://linear.app/team-hydraulics/issue/BAC-120/applicant-view-personal-details