Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/BE-37 applicants job submission #47

Closed
wants to merge 5 commits into from
Closed

Feat/BE-37 applicants job submission #47

wants to merge 5 commits into from

Conversation

Jayhmz
Copy link
Collaborator

@Jayhmz Jayhmz commented Nov 18, 2022

This pull request is to submit this feature for review and update on the issue #37
Linear link: https://linear.app/team-hydraulics/issue/BAC-37/applicants-job-submission

@volunux
Copy link
Collaborator

volunux commented Nov 19, 2022

  • value="apply" should be renamed to fit the purpose and details of controller like value="job-submission" or value="submission"
  • jobSubmissionRepository should be renamed to repository since its type identifies the purpose as JobSubmissionRepository with the different initial alphabet j and J
  • All other existing implementations is okay and can be continued.
  • Do review your work and continue with tasks and until it is done before review

@Jayhmz
Copy link
Collaborator Author

Jayhmz commented Nov 19, 2022

okay, thanks for the review

@Jayhmz Jayhmz closed this Nov 21, 2022
@Jayhmz Jayhmz deleted the feat/BE-37-applicants-job-submission branch November 21, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayhmz @volunux