Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getAllAppliers endpoint #79

Closed
wants to merge 3 commits into from
Closed

added getAllAppliers endpoint #79

wants to merge 3 commits into from

Conversation

ManasDroid
Copy link
Collaborator

issue #29

@ManasDroid
Copy link
Collaborator Author

please review it and guide me

@volunux
Copy link
Collaborator

volunux commented Nov 19, 2022

  • You have to .gitignore all the .idea folders and all ide related folders and those not part of the project.
    How to add folder .gitignore
  • ResponseEntity is not needed since @RestController already takes care of deserialization of class as JSON.
  • ApplierController is missing necessary annotations, do check the existing controller classes.
  • This @GetMapping("/api/v1/appliers") doesn't conform to project standard. Class should be annotated with

@RestController
@RequestMapping(value ="applier")

Then @GetMapping("/entries")

  • Implementations of repository for retrieving all Appliers doesn't follow existing project standard even though it works, you would not be happy to read a code you do not understand by other members. Project members work must align and be uniform so that it can be meaningful to all.

@ManasDroid ManasDroid closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants