Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat get verified user by #30

Merged
merged 10 commits into from
Nov 17, 2022
Merged

Feat get verified user by #30

merged 10 commits into from
Nov 17, 2022

Conversation

dasaint001
Copy link
Collaborator

add get verified user by id under issue #18

Benrobo and others added 8 commits November 16, 2022 13:59
@dasaint001 dasaint001 requested a review from Benrobo November 17, 2022 05:51
@Benrobo Benrobo merged commit d652db3 into dev Nov 17, 2022
Copy link
Collaborator

@Benrobo Benrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing... By all means, I want to encourage writing of clean code within this project, so please leverage the sendResponse function/class, this way, we know we have a structured way of sending response to client... And the frontend handling the data would know how to handle state management from the response gotten.

Thanks.

@Priceless-P
Copy link
Collaborator

Please should the controller be UserController or UsersController? @Benrobo @dasaint001

@Benrobo
Copy link
Collaborator

Benrobo commented Nov 17, 2022

@Priceless-P let it be UserController just has @dasaint001 has created

@Benrobo Benrobo deleted the feat-getVerifiedUserById branch November 17, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants