Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/88 #89

Merged
merged 17 commits into from
Nov 15, 2024
Merged

Bug/88 #89

merged 17 commits into from
Nov 15, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Update s2s notebook for handling of geometry (json object not string)
  • Add notebook dependeny group

How to test it

  • Create your poetry environment with poetry install --with notebook (@bpstewar this will add your missing dependencies)
  • Select this environment to run your notebook
  • Run through the s2s notebook

Other notes

  • Closes S2S library h3 error #88
  • @bpstewar is poetry is problematic for end-users for whatever reason, we can export a requirements.txt file from poetry that you could use with conda or pip: poetry export --with notebook -f requirements.txt --without-hashes --output requirements.txt

@zacdezgeo zacdezgeo added the bug Something isn't working label Nov 15, 2024
@zacdezgeo zacdezgeo requested a review from bpstewar November 15, 2024 10:33
@zacdezgeo zacdezgeo self-assigned this Nov 15, 2024
@bpstewar bpstewar merged commit 886493f into feature/h3ronpy Nov 15, 2024
1 of 2 checks passed
@zacdezgeo zacdezgeo deleted the bug/88 branch November 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants